158 remove colors file#260
Open
Noamili wants to merge 24 commits into
Open
Conversation
…ommunity#235) * test: add e2e infra with playwright and a sample test * test: add github action for e2e test * test: add config for framework spin-up
* feat: add Yedidya Rashi profile (Pull-Request-Community#220) * fix: randomShuffle isn't working correctly (Pull-Request-Community#167)
…issue241 Yedidyar/issue241
* inital commit * revert change Co-authored-by: noa <noamil@zencity.io>
|
Preview on netlify: https://deploy-preview-260--pull-request.netlify.app/ |
✅ Deploy Preview for agitated-hoover-61371e ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Noamili
force-pushed
the
158-Remove-colors-file
branch
from
4e8f3c0 to
28ac821
Compare
Noamili
force-pushed
the
158-Remove-colors-file
branch
from
6a7c4da to
449fdf3
Compare
Collaborator
|
@Noamili please fix conflicts |
Noamili
force-pushed
the
158-Remove-colors-file
branch
from
9fd6b96 to
d97a360
Compare
Noamili
commented
Jul 25, 2022
| rgba(220, 102, 94, 0.6) 100% | ||
| ); | ||
| $purple-100: rgba(11, 0, 142, 0.3); | ||
| $purple-200: rgba(11, 0, 142, 0.1); |
Contributor
Author
There was a problem hiding this comment.
how can I avoid using opacity?
Noamili
commented
Jul 25, 2022
| @@ -14,6 +16,6 @@ | |||
| align-items: center; | |||
| justify-content: center; | |||
| font-size: 14px; | |||
Contributor
Author
There was a problem hiding this comment.
should I change this to rem?
Noamili
commented
Jul 25, 2022
| @@ -10,7 +12,7 @@ | |||
| justify-content: center; | |||
| font-weight: bold; | |||
| font-size: 36px; | |||
Contributor
Author
There was a problem hiding this comment.
should I change this to rem?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #158